images not displaying, only seeing links

Dashrender

@MattSpeller said:

Quick, post funny images of @Dashrender

Whilst not really funny but definitely a classic (Dude on the left with the shoulder pads

Took long enough.

nadnerB

@Dashrender Still catching up from being AFK for most of yesterday.

BDHarrington7

@mlnews said:

Just fell back to 0.2.1 and things are working again. Another bad plugin update. So unreliable. This is the problem with keeping functionality in plugins.

Plugin author here. I've tested this on nbb 0.9.2, both installing from scratch and upgrading, and it works fine. Ironically, the biggest changes to the plugin were adding a test suite. What problems did you guys have? anything in the error logs?

scottalanmiller

@BDHarrington7 said:

@mlnews said:

Just fell back to 0.2.1 and things are working again. Another bad plugin update. So unreliable. This is the problem with keeping functionality in plugins.

Plugin author here. I've tested this on nbb 0.9.2, both installing from scratch and upgrading, and it works fine. Ironically, the biggest changes to the plugin were adding a test suite. What problems did you guys have? anything in the error logs?

What happened here was that the links simply stopped rendering. Nothing weird, it was just as if the plugin was not there at all.

BDHarrington7

There should have at least been some error, did you try a restart of the community? What version are you on?

scottalanmiller

@BDHarrington7 said:

There should have at least been some error, did you try a restart of the community? What version are you on?

NodeBB 0.9.3

It was reloaded more than once. Not restarted completely.

scottalanmiller

We are at very high load right now, but we can test this again when the volume drops (we are unable to predict when that might be, it will, we just can't tell when.)

BDHarrington7

Ok cool. In my testing the absense of a reload or restart didn't break anything. I didn't try 0.9.3 but I can try that later to see if something changed

scottalanmiller

Thanks.

BDHarrington7

Are you guys on 0.9.3 (the tag?) or 0.9.x (the branch?) I'm on the tag, and I can't even go to a topic without getting a circular reference error

BDHarrington7

Sorry, I can't reproduce this, tried going from 0.2.1 -> 0.2.2 on nbb 0.9.x branch latest (cf5decf5de6f3b1e0690d2c4deab1565c21989ef). Both not reloading nbb and also reloading after upgrade. I'm closing the issue, but if you can get me an error log, please reopen it.

scottalanmiller

Branch.